Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2306263002: Fix default value of --output-chartjson-data '' -> None (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix default value of --output-chartjson-data '' -> None Having it as '' caused it to resolve to CWD when unset due to type=os.path.realpath. Then, perf_test_instance.py tried to write to CWD as a file. Also removes third_party/appurify-python from .gitignore in order to appease test_runner.pydeps presubmit. TBR=rnephew BUG=609365 Committed: https://crrev.com/144057ca2c57f655112212ba1efbf90c9ab26b93 Cr-Commit-Position: refs/heads/master@{#416466}

Patch Set 1 #

Patch Set 2 : revert pydeps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
agrieve
On 2016/09/04 01:11:46, agrieve wrote: > Description was changed from > > ========== > Fix ...
4 years, 3 months ago (2016-09-04 01:12:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306263002/1
4 years, 3 months ago (2016-09-04 01:12:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/135858)
4 years, 3 months ago (2016-09-04 01:33:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306263002/20001
4 years, 3 months ago (2016-09-04 02:29:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-04 03:26:53 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 03:28:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/144057ca2c57f655112212ba1efbf90c9ab26b93
Cr-Commit-Position: refs/heads/master@{#416466}

Powered by Google App Engine
This is Rietveld 408576698