Move more error detection out of Scope

Move more error detection out of Scope

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/04d3701fbe9c6a3b0bf182357dfcb9477a80e0f9

[Brian Wilkerson, 2016-09-02 22:27:59]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-09-02 23:46:50]

LGTM

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/resolver/scope.dart (right):

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/resolver/scope.dart:33: void _defineElements(block) {
Type for "block"?

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/resolver/scope.dart:36: }
This could be written as:
elementsInBlock(block).forEach(define);

Hm... OTOH, forEach(), if not inlined, will have a megamorphic lookup :-(

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/error_verifier.dart:6701: }
I think here it also could be written more concise.
Maybe even inline it.
BlockScope.elementsInBlock(block).forEach(_elements.add);

[Brian Wilkerson, 2016-09-03 17:12:37]

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/resolver/scope.dart (right):

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/resolver/scope.dart:33: void _defineElements(block) {
Done

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/resolver/scope.dart:36: }
Leaving it as is.

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2306223002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/error_verifier.dart:6701: }
I went with "_elements.addAll(BlockScope.elementsInBlock(block));"

[Brian Wilkerson, 2016-09-03 17:13:00]

Description was changed from

==========
Move more error detection out of Scope
==========

to

==========
Move more error detection out of Scope

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/04d3701fbe9c6a3b0bf182357dfcb9477a80e0f9
==========

[Brian Wilkerson, 2016-09-03 17:13:02]

Committed patchset #2 (id:20001) manually as
04d3701fbe9c6a3b0bf182357dfcb9477a80e0f9 (presubmit successful).