The android test launcher now silently waits for a debugger

The android test launcher now silently waits for a debugger

There seems to be no good reason to use the non-silent WaitForDebugger(),
and the silent one is much easier to continue from in gdb, so now the
android native test launcher silently waits too.

BUG=643818
Committed: https://crrev.com/e3184756eeeb956f15ff80cd509893d34b884942
Cr-Commit-Position: refs/heads/master@{#416373}

[watk, 2016-09-02 21:54:07]

watk@chromium.org changed reviewers:
+ jbudorick@chromium.org

[watk, 2016-09-02 21:54:07]

Thanks jbudorick@.

With this CL there's only one instance of a non-silent wait left in
ppapi_plugin_main.cc ¯\_(ツ)_/¯

[jbudorick, 2016-09-02 21:55:27]

lgtm

I tried this out locally and had the same experience you did -- silent worked
well, nonsilent was unusable. Thanks for fixing it :)

[watk, 2016-09-02 21:59:36]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-09-02 22:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-09-02 22:00:24]

On 2016/09/02 21:55:27, jbudorick wrote:
> lgtm
> 
> I tried this out locally and had the same experience you did -- silent worked
> well, nonsilent was unusable. Thanks for fixing it :)

Nice, I'll update the chromium-dev instructions about this too.

[commit-bot: I haz the power, 2016-09-02 22:41:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 22:44:55]

Description was changed from

==========
The android test launcher now silently waits for a debugger

There seems to be no good reason to use the non-silent WaitForDebugger(),
and the silent one is much easier to continue from in gdb, so now the
android native test launcher silently waits too.

BUG=643818
==========

to

==========
The android test launcher now silently waits for a debugger

There seems to be no good reason to use the non-silent WaitForDebugger(),
and the silent one is much easier to continue from in gdb, so now the
android native test launcher silently waits too.

BUG=643818

Committed: https://crrev.com/e3184756eeeb956f15ff80cd509893d34b884942
Cr-Commit-Position: refs/heads/master@{#416373}
==========

[commit-bot: I haz the power, 2016-09-02 22:44:56]

Patchset 1 (id:??) landed as
https://crrev.com/e3184756eeeb956f15ff80cd509893d34b884942
Cr-Commit-Position: refs/heads/master@{#416373}