Chromium Code Reviews| Index: pkg/compiler/lib/src/ssa/builder.dart |
| diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart |
| index c23f3a6bfcf3f0dd5c3807e5e77fbb86ebc9b705..3d09ba0f3d81880f9cd6d16d38f78e6a02bad391 100644 |
| --- a/pkg/compiler/lib/src/ssa/builder.dart |
| +++ b/pkg/compiler/lib/src/ssa/builder.dart |
| @@ -868,7 +868,7 @@ class SsaBuilder extends ast.Visitor |
| /// A stack of [DartType]s the have been seen during inlining of factory |
|
Harry Terkelsen
2016/09/02 21:46:22
if you want:
"the have" -> "that have"
sra1
2016/09/02 21:50:27
Done.
|
| /// constructors. These types are preserved in [HInvokeStatic]s and |
| - /// [HForeignNew]s inside the inline code and registered during code |
| + /// [HCreate]s inside the inline code and registered during code |
| /// generation for these nodes. |
| // TODO(karlklose): consider removing this and keeping the (substituted) |
| // types of the type variables in an environment (like the [LocalsHandler]). |
| @@ -1498,8 +1498,8 @@ class SsaBuilder extends ast.Visitor |
| HInstruction newObject; |
| if (!isNativeUpgradeFactory) { |
| - newObject = new HForeignNew( |
| - classElement, ssaType, constructorArguments, instantiatedTypes); |
| + newObject = new HCreate( |
| + classElement, constructorArguments, ssaType, instantiatedTypes); |
| if (function != null) { |
| // TODO(johnniwinther): Provide source information for creation |
| // through synthetic constructors. |
| @@ -2431,7 +2431,7 @@ class SsaBuilder extends ast.Visitor |
| TypeMask type = |
| new TypeMask.nonNullExact(closureClassElement, compiler.world); |
| - push(new HForeignNew(closureClassElement, type, capturedVariables) |
| + push(new HCreate(closureClassElement, capturedVariables, type) |
| ..sourceInformation = sourceInformationBuilder.buildCreate(node)); |
| Element methodElement = nestedClosureData.closureElement; |