Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2306173003: Add a new QuicFlagSaver class for saving/restoring the values of QUIC flags in tests. (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new QuicFlagSaver class for saving/restoring the values of QUIC flags in tests. Also move the list of quic flags and their values into quic_flags_list.h which can be #included elsewhere. Committed: https://crrev.com/b1c5698853e879c9fe7d8375ff7e5988d3e42152 Cr-Commit-Position: refs/heads/master@{#416403}

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -291 lines) Patch
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M net/quic/core/quic_flags.h View 1 chunk +3 lines, -42 lines 0 comments Download
M net/quic/core/quic_flags.cc View 1 chunk +3 lines, -161 lines 0 comments Download
A + net/quic/core/quic_flags_list.h View 1 chunk +46 lines, -43 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_protocol_test.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_session_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 1 chunk +5 lines, -12 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Ryan Hamilton
4 years, 3 months ago (2016-09-02 21:44:54 UTC) #3
Jana
lgtm Very clever! I LOVE this use of macros, and the simplification of merge that ...
4 years, 3 months ago (2016-09-02 21:53:24 UTC) #6
Ryan Hamilton
On 2016/09/02 21:53:24, Jana wrote: > lgtm > > Very clever! I LOVE this use ...
4 years, 3 months ago (2016-09-02 22:01:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306173003/40001
4 years, 3 months ago (2016-09-02 23:59:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-03 00:07:06 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:11:42 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b1c5698853e879c9fe7d8375ff7e5988d3e42152
Cr-Commit-Position: refs/heads/master@{#416403}

Powered by Google App Engine
This is Rietveld 408576698