Add aliases to bot-page and refactor duplicated code

appengine/swarming/elements/res/js/alias.js

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
+// TODO(kjlubick): add tests for this code
+
 this.swarming = this.swarming || {};
 this.swarming.alias = this.swarming.alias || (function(){
   var ANDROID_ALIASES = {
     "bullhead": "Nexus 5X",
     "flo": "Nexus 7 (2013)",
     "flounder": "Nexus 9",
     "foster": "NVIDIA Shield",
     "fugu": "Nexus Player",
     "grouper": "Nexus 7 (2012)",
     "hammerhead": "Nexus 5",
@@ skipping 38 matching lines @@
   var ALIAS_REGEXP = /.+ \((.*)\)/;
 
   var alias = {};
 
   alias.DIMENSIONS_WITH_ALIASES = ["device_type", "gpu"];
 
   alias.android = function(dt) {
     return ANDROID_ALIASES[dt] || UNKNOWN;
   };
 
-  // alias.apply is the consistent way to modify a string to show its alias.
-  alias.apply = function(orig, alias) {
-    return alias +" ("+orig+")";
+  // alias.apply tries to alias the string "orig" based on what "type" it is.
+  // If type is in DIMENSIONS_WITH_ALIASES, the appropriate alias (e.g. gpu)
+  // is automatically applied.  Otherwise, "type" is treated as the alias.
+  // If type is known, but there is no matching alias (e.g. for gpu: FOOBAR)
+  // the original will be returned.
+  alias.apply = function(orig, type) {
+    var aliaser = aliasMap[type];
+    if (!aliaser) {
+      // treat type as the actual alias
+      return type + " ("+orig+")";
+    }
+    var alias = aliaser(orig);
+    if (alias !== "unknown") {
+      return alias + " ("+orig+")";
+    }
+    return orig;
   };
 
   alias.gpu = function(gpu) {
     return GPU_ALIASES[gpu] || UNKNOWN;
   };
 
   // alias.unapply will return the base dimension/state with its alias removed
   // if it had one.  This is handy for sorting and filtering.
   alias.unapply = function(str) {
     var match = ALIAS_REGEXP.exec(str);
     if (match) {
       return match[1];
     }
     return str;
   };
 
+  var aliasMap = {
+    "device_type": alias.android,
+    "gpu": alias.gpu,
+  }
+
   return alias;
 })();