tools/perf/page_sets/todomvc.py - Issue 2306073002: Revert of Add some more categories for V8.TodoMVC to see what keeps us non-idle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/todomvc.py

Issue 2306073002: Revert of Add some more categories for V8.TodoMVC to see what keeps us non-idle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/todomvc.py

diff --git a/tools/perf/page_sets/todomvc.py b/tools/perf/page_sets/todomvc.py

index 115b1a9cb4ad800e840b35865994e1573af1fddf..4f095ecf29f153fe2064930873207a57a04740df 100644

--- a/tools/perf/page_sets/todomvc.py

+++ b/tools/perf/page_sets/todomvc.py

@@ -39,13 +39,10 @@

"""

this.becameIdle = false;

this.idleCallback = function(deadline) {

- let idletime = deadline.timeRemaining();

- console.time("time remaining: " + idletime);

- if (idletime > 20)

+ if (deadline.timeRemaining() > 20)

this.becameIdle = true;

else

requestIdleCallback(this.idleCallback);

- console.timeEnd("time remaining: " + idletime);

};

requestIdleCallback(this.idleCallback);

"""

« no previous file with comments | « tools/perf/benchmarks/v8.py ('k') | no next file » | no next file with comments »