Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2306033002: [turbofan] Migrate remaining DataView builtins to C++. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Migrate remaining DataView builtins to C++. R=franzih@chromium.org BUG=v8:3533 Committed: https://crrev.com/97f6266f564e0b8a6f8ecd2f12cfadfccccff511 Cr-Commit-Position: refs/heads/master@{#39143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -294 lines) Patch
M src/bootstrapper.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/builtins/builtins-dataview.cc View 1 chunk +204 lines, -0 lines 0 comments Download
M src/js/typedarray.js View 2 chunks +0 lines, -65 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -17 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +0 lines, -212 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-02 12:16:37 UTC) #1
Benedikt Meurer
Hey Franziska, Here's some final cleanup for the DataView builtins. Almost completely mechanical. Please take ...
4 years, 3 months ago (2016-09-02 12:17:22 UTC) #4
Franzi
lgtm
4 years, 3 months ago (2016-09-02 18:28:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306033002/1
4 years, 3 months ago (2016-09-02 18:29:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 18:31:52 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:32:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97f6266f564e0b8a6f8ecd2f12cfadfccccff511
Cr-Commit-Position: refs/heads/master@{#39143}

Powered by Google App Engine
This is Rietveld 408576698