Issue 230603002: Revert "Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and Get…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 230603002: Revert "Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and Get… (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttributes())." This reverts commit r20606 for breaking tests on windows. TBR=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20607

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -71 lines)			Patch
	M	src/elements.h	View		3 chunks	+20 lines, -2 lines	0 comments	Download
	M	src/elements.cc	View		20 chunks	+94 lines, -69 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

Committed patchset #1 manually as r20607 (tree was closed).

6 years, 8 months ago (2014-04-09 10:58:43 UTC) #1

Yang

6 years, 8 months ago (2014-04-09 12:13:54 UTC) #2

Message was sent while issue was closed.

On 2014/04/09 10:58:43, Igor Sheludko wrote:
> Committed patchset #1 manually as r20607 (tree was closed).

The actual problem is very flaky and independent from this change.  The fix is
here: https://codereview.chromium.org/230693002/

Expand Messages | Collapse Messages