Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2306023002: binding: Makes WindowProperties.constructor throw a TypeError. (Closed)

Created:
2 years, 10 months ago by Yuki
Modified:
2 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes WindowProperties.constructor throw a TypeError. As same as a Window object, we do not need to support a constructor for WindowProperties object. BUG=643357 Committed: https://crrev.com/e2247f1ab98f3393373232cde1538879b2f9dee9 Cr-Commit-Position: refs/heads/master@{#416257}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Updated a layout test. #

Messages

Total messages: 12 (6 generated)
Yuki
Could you review this CL?
2 years, 10 months ago (2016-09-02 11:25:29 UTC) #4
haraken
LGTM Can we add a test?
2 years, 10 months ago (2016-09-02 11:31:01 UTC) #5
Yuki
On 2016/09/02 11:31:01, haraken wrote: > LGTM > > Can we add a test? Added ...
2 years, 10 months ago (2016-09-02 11:54:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306023002/40001
2 years, 10 months ago (2016-09-02 11:54:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 10 months ago (2016-09-02 13:37:18 UTC) #10
commit-bot: I haz the power
2 years, 10 months ago (2016-09-02 13:39:22 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e2247f1ab98f3393373232cde1538879b2f9dee9
Cr-Commit-Position: refs/heads/master@{#416257}

Powered by Google App Engine
This is Rietveld 408576698