Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 23060021: [Android WebView] Call RequestProcessGL on UI thread (Closed)

Created:
7 years, 4 months ago by boliu
Modified:
3 years, 6 months ago
Reviewers:
joth
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Call RequestProcessGL on UI thread Currently we are not guaranteed to call RequestProcessGL on the UI thread which is a threading bug that can cause coruption/crashes. BUG=277055 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218828

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments, merge in crrev.com/22861018 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M android_webview/browser/in_process_view_renderer.cc View 1 3 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
m30 crbug coming before landing
7 years, 4 months ago (2013-08-21 17:53:47 UTC) #1
joth
https://codereview.chromium.org/23060021/diff/1/android_webview/browser/in_process_view_renderer.cc File android_webview/browser/in_process_view_renderer.cc (right): https://codereview.chromium.org/23060021/diff/1/android_webview/browser/in_process_view_renderer.cc#newcode179 android_webview/browser/in_process_view_renderer.cc:179: LOG(ERROR) << "Failed to request DrawGL. Probably going to ...
7 years, 4 months ago (2013-08-21 18:37:29 UTC) #2
boliu
both done
7 years, 4 months ago (2013-08-21 19:00:09 UTC) #3
joth
lgtm
7 years, 4 months ago (2013-08-21 19:11:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/23060021/7001
7 years, 4 months ago (2013-08-21 20:50:31 UTC) #5
commit-bot: I haz the power
Change committed as 218828
7 years, 4 months ago (2013-08-21 20:54:33 UTC) #6
parmar.priyanka22
3 years, 6 months ago (2017-06-24 20:22:09 UTC) #7
Message was sent while issue was closed.
On 2013/08/21 20:54:33, commit-bot: I haz the power wrote:
> Change committed as 218828

Well this is the best thing http://techmero.in

Powered by Google App Engine
This is Rietveld 408576698