Issue 23060018: Fix migration checks and extend them to the Scavenger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23060018: Fix migration checks and extend them to the Scavenger. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger

Modified:
7 years, 4 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix migration checks and extend them to the Scavenger. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16265

Patch Set 2 : Address nit. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -13 lines)			Patch
M	src/heap.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/heap-inl.h	View		1 chunk	+37 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1	2 chunks	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM with one nit https://codereview.chromium.org/23060018/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/23060018/diff/1/src/mark-compact.cc#newcode2746 src/mark-compact.cc:2746: // TODO(hpayer): Replace these checks ...

7 years, 4 months ago (2013-08-21 18:20:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r16265.

Expand Messages | Collapse Messages

Issue 23060018: Fix migration checks and extend them to the Scavenger. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address nit. #

Messages