Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: cc/output/gl_renderer.cc

Issue 23060011: Pass the quad's rect (contents_rect) origin to skia image filters as an offset in the CTM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modify test to cover incorrect clipping offsets, and to use blue_yellow.png as a result. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index e35b6975f1ea79f457e87f76229dea64e9414fed..62122c812d2fd9ff4a75355947a9fb61e9065340 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -513,6 +513,7 @@ static inline SkBitmap ApplyFilters(GLRenderer* renderer,
static SkBitmap ApplyImageFilter(GLRenderer* renderer,
ContextProvider* offscreen_contexts,
+ gfx::Point origin,
SkImageFilter* filter,
ScopedResource* source_texture_resource) {
if (!filter)
@@ -577,6 +578,7 @@ static SkBitmap ApplyImageFilter(GLRenderer* renderer,
SkPaint paint;
paint.setImageFilter(filter);
canvas.clear(SK_ColorTRANSPARENT);
+ canvas.translate(SkIntToScalar(-origin.x()), SkIntToScalar(-origin.y()));
danakj 2013/08/29 02:07:16 Can you add a TODO here stating that the filter sh
Stephen White 2013/08/29 17:07:00 Done.
canvas.drawSprite(source, 0, 0, &paint);
// Flush skia context so that all the rendered stuff appears on the
@@ -778,6 +780,7 @@ void GLRenderer::DrawRenderPassQuad(DrawingFrame* frame,
} else {
filter_bitmap = ApplyImageFilter(this,
frame->offscreen_context_provider,
+ quad->rect.origin(),
quad->filter.get(),
contents_texture);
}
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_pixeltest_filters.cc » ('j') | cc/trees/layer_tree_host_pixeltest_filters.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698