chrome/test/mini_installer/config/chrome_installed.prop - Issue 23060002: Implement the window verifier in the Automated Installer Testing Framework.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/mini_installer/config/chrome_installed.prop

Issue 23060002: Implement the window verifier in the Automated Installer Testing Framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "RegistryEntries": {	2 "RegistryEntries": {

3 "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-A FF1-A69D9E530F96}":	3 "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-A FF1-A69D9E530F96}":

4 {"exists": true}	4 {"exists": true}

	5 },

	6 "Windows": {

	7 "Welcome to Chrome": {"exists": true}
	gab 2013/08/13 17:49:27 The installer launches chrome.exe and exits shortl The installer launches chrome.exe and exits shortly after without waiting for it to actually launch. Asserting that the window is up immediately after the install completes will result in a flaky test as it relies on chrome.exe having been scheduled by the OS on the machine and having made it far enough to have a window with the right title before this verifier kicks in. Instead I think we should add --do-not-launch-chrome to the install command being tested. Then add another command which runs chrome.exe and then verifies another state made of chrome_installed.prop + chrome_running.prop. The command that runs chrome.exe should also be made so that it only returns when the window is up (essentially using the verifier you wrote to probe for the Chrome window in a loop before returning).
5 }	8 }

6 }	9 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/mini_installer/config/chrome_not_installed.prop » ('j') | chrome/test/mini_installer/config/chrome_not_installed.prop » ('J')