Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2305983002: DevTools: Modify shadow-editor canvas colors to work better with dark theme (Closed)

Created:
4 years, 3 months ago by flandy
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Modify shadow-editor canvas colors to work better with dark theme BUG=639095 Committed: https://crrev.com/d506d0d36382776ad26952c89f698c228c0f9111 Cr-Commit-Position: refs/heads/master@{#417108}

Patch Set 1 #

Patch Set 2 : Preserve blues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/cssShadowEditor.css View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/slider.css View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
flandy
Please take a look.
4 years, 3 months ago (2016-09-02 02:36:31 UTC) #2
lushnikov
could you please add a screenshot? what does this patch look like in both original ...
4 years, 3 months ago (2016-09-06 15:10:53 UTC) #3
flandy
On 2016/09/06 15:10:53, lushnikov wrote: > could you please add a screenshot? what does this ...
4 years, 3 months ago (2016-09-06 18:02:37 UTC) #4
lushnikov
lgtm
4 years, 3 months ago (2016-09-07 21:22:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305983002/20001
4 years, 3 months ago (2016-09-07 21:32:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 23:04:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 23:05:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d506d0d36382776ad26952c89f698c228c0f9111
Cr-Commit-Position: refs/heads/master@{#417108}

Powered by Google App Engine
This is Rietveld 408576698