Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5521)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2305973002: [MD-Settings] Make the Advanced button into an actual button. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index cf0f7de220fb65d35db68f4588c00cb81f69a5ca..f90b8431622e264cf34dfa5fb9121026881d542e 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -2,6 +2,7 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/html/promise_resolver.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="/about_page/about_page.html">
<link rel="import" href="/advanced_page/advanced_page.html">
<link rel="import" href="/basic_page/basic_page.html">
@@ -13,6 +14,9 @@
<template>
<style>
#advancedToggle {
+ --paper-button: {
+ text-transform: none;
+ }
@apply(--settings-actionable);
align-items: center;
display: flex;
@@ -69,10 +73,10 @@
showPages_.basic, hasExpandedSection_, previousShowPages_)]]">
<div id="toggleSpacer"></div>
<div id="toggleContainer">
- <div id="advancedToggle" on-tap="toggleAdvancedPage_">
Dan Beam 2016/09/02 21:30:55 could we just use role="button" or <button> instea
hcarmona 2016/09/02 21:55:19 Checked with bettes@ about ripple: http://crbug.co
+ <paper-button id="advancedToggle" on-tap="toggleAdvancedPage_">
<span>$i18n{advancedPageTitle}</span>
<iron-icon icon="[[arrowState_(showPages_.advanced)]]"></iron-icon>
- </div>
+ </paper-button>
</div>
</template>
<template is="dom-if" if="[[showPages_.advanced]]">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698