[MD-Settings] Make the Advanced button into an actual button.

[MD-Settings] Make the Advanced button into an actual button.

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG=626879, 643309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/305ffc4f4518e097789f478cad137100fd938d5a
Cr-Commit-Position: refs/heads/master@{#416440}

[hcarmona, 2016-09-02 01:17:46]

Description was changed from

==========
[MD-Settings] Make the Advanced button into an actual button.

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG=626879,643309
==========

to

==========
[MD-Settings] Make the Advanced button into an actual button.

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG=626879,643309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-09-02 01:17:51]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 01:26:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 01:26:14]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[hcarmona, 2016-09-02 20:44:43]

hcarmona@chromium.org changed reviewers:
+ dschuyler@chromium.org

[hcarmona, 2016-09-02 20:44:44]

PTAL

[Dan Beam, 2016-09-02 21:30:55]

https://codereview.chromium.org/2305973002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_main/settings_main.html (left):

https://codereview.chromium.org/2305973002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_main/settings_main.html:72: <div
id="advancedToggle" on-tap="toggleAdvancedPage_">
could we just use role="button" or <button> instead?  i don't know that we want
a ripple on this

[hcarmona, 2016-09-02 21:55:20]

https://codereview.chromium.org/2305973002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_main/settings_main.html (left):

https://codereview.chromium.org/2305973002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_main/settings_main.html:72: <div
id="advancedToggle" on-tap="toggleAdvancedPage_">
On 2016/09/02 21:30:55, Dan Beam wrote:
> could we just use role="button" or <button> instead?  i don't know that we
want
> a ripple on this

Checked with bettes@ about ripple: http://crbug.com/643309

[dschuyler, 2016-09-03 00:38:11]

LGTM

[hcarmona, 2016-09-03 01:05:23]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-09-03 01:05:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:41:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-03 03:44:45]

Description was changed from

==========
[MD-Settings] Make the Advanced button into an actual button.

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG=626879,643309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD-Settings] Make the Advanced button into an actual button.

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG=626879,643309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/305ffc4f4518e097789f478cad137100fd938d5a
Cr-Commit-Position: refs/heads/master@{#416440}
==========

[commit-bot: I haz the power, 2016-09-03 03:44:46]

Patchset 1 (id:??) landed as
https://crrev.com/305ffc4f4518e097789f478cad137100fd938d5a
Cr-Commit-Position: refs/heads/master@{#416440}