Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: src/snapshot/code-serializer.cc

Issue 2305903002: [wasm] reuse the first compiled module (Closed)
Patch Set: feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/snapshot/code-serializer.cc
diff --git a/src/snapshot/code-serializer.cc b/src/snapshot/code-serializer.cc
index 8d2f5d933994cbab63e6451973137fe11c50496a..5011558f4623cd71097e6cd0f943af5d670fa193 100644
--- a/src/snapshot/code-serializer.cc
+++ b/src/snapshot/code-serializer.cc
@@ -98,6 +98,10 @@ void CodeSerializer::SerializeObject(HeapObject* obj, HowToCode how_to_code,
UNREACHABLE();
}
+ if (SkipOver(obj)) {
vogelheim 2016/09/05 08:09:52 I would have preferred a more expressive name, or
Yang 2016/09/10 03:58:37 I wonder whether it' not cleaner to implement a se
+ return SerializeObject(*isolate()->factory()->undefined_value(),
+ how_to_code, where_to_point, skip);
+ }
// Past this point we should not see any (context-specific) maps anymore.
CHECK(!obj->IsMap());
// There should be no references to the global object embedded.

Powered by Google App Engine
This is Rietveld 408576698