Remove unnessary includes of parser.h

Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

BUG=v8:5294
Committed: https://crrev.com/6dd2bc20b46f9a9e341b2549c6db6018ffcba448
Cr-Commit-Position: refs/heads/master@{#39141}

[adamk, 2016-09-01 22:24:01]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 22:24:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:51:11]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-09-02 00:05:24]

Description was changed from

==========
Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

R=mstarzinger@chromium.org
==========

to

==========
Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

BUG=v8:5294
==========

[adamk, 2016-09-02 00:06:04]

adamk@chromium.org changed reviewers:
+ marja@chromium.org

[adamk, 2016-09-02 00:06:05]

+marja, who's actually the m* person who was doing this most recently (my brain
got confused).

Keeping mstarzinger on the R line due to all the OWNERS files this touches.

[marja, 2016-09-02 07:47:45]

marja@chromium.org changed reviewers:
+ titzer@chromium.org

[marja, 2016-09-02 07:47:46]

Nice!

lgtm modulo comments

mstarzinger@ is ooo, maybe titzer@ could OWNERS-review this

https://codereview.chromium.org/2305883002/diff/1/src/asmjs/asm-js.h
File src/asmjs/asm-js.h (right):

https://codereview.chromium.org/2305883002/diff/1/src/asmjs/asm-js.h#newcode15
src/asmjs/asm-js.h:15: #include "src/parsing/parse-info.h"
This #include is not needed - a forward declaration is enough.

https://codereview.chromium.org/2305883002/diff/1/src/ast/ast.cc
File src/ast/ast.cc (left):

https://codereview.chromium.org/2305883002/diff/1/src/ast/ast.cc#oldcode16
src/ast/ast.cc:16: #include "src/parsing/parser.h"
Cool!

[titzer, 2016-09-02 07:53:47]

On 2016/09/02 07:47:46, marja wrote:
> Nice!
> 
> lgtm modulo comments
> 
> mstarzinger@ is ooo, maybe titzer@ could OWNERS-review this
> 
> https://codereview.chromium.org/2305883002/diff/1/src/asmjs/asm-js.h
> File src/asmjs/asm-js.h (right):
> 
> https://codereview.chromium.org/2305883002/diff/1/src/asmjs/asm-js.h#newcode15
> src/asmjs/asm-js.h:15: #include "src/parsing/parse-info.h"
> This #include is not needed - a forward declaration is enough.
> 
> https://codereview.chromium.org/2305883002/diff/1/src/ast/ast.cc
> File src/ast/ast.cc (left):
> 
> https://codereview.chromium.org/2305883002/diff/1/src/ast/ast.cc#oldcode16
> src/ast/ast.cc:16: #include "src/parsing/parser.h"
> Cool!

lgtm

[adamk, 2016-09-02 17:05:54]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 17:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-02 17:06:33]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org
- mstarzinger@chromium.org

[adamk, 2016-09-02 17:06:34]

titzer is unfortunately not sufficient, adding bmeurer.

Benedikt, let me know if you'd prefer me just TBRing things like this to you in
future (no code changes, just moving around includes).

https://codereview.chromium.org/2305883002/diff/1/src/asmjs/asm-js.h
File src/asmjs/asm-js.h (right):

https://codereview.chromium.org/2305883002/diff/1/src/asmjs/asm-js.h#newcode15
src/asmjs/asm-js.h:15: #include "src/parsing/parse-info.h"
On 2016/09/02 07:47:45, marja wrote:
> This #include is not needed - a forward declaration is enough.

Done.

[Benedikt Meurer, 2016-09-02 17:08:24]

TBR would be fine with me for such changes. LGTM.

[commit-bot: I haz the power, 2016-09-02 17:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:18:29]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[adamk, 2016-09-02 17:22:24]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 17:22:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:45:44]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-09-02 17:46:16]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-09-02 17:46:17]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
marja@chromium.org, bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2305883002/#ps40001
(title: "More fixes in asm-js.h")

[commit-bot: I haz the power, 2016-09-02 17:46:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:48:37]

Description was changed from

==========
Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

BUG=v8:5294
==========

to

==========
Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

BUG=v8:5294
==========

[commit-bot: I haz the power, 2016-09-02 17:48:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 17:48:52]

Description was changed from

==========
Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

BUG=v8:5294
==========

to

==========
Remove unnessary includes of parser.h

This makes for slightly faster rebuilds when touching parser-base.h
(which changes frequently!). Also takes care of an old TODO,
moving CompileTimeValue into its own file under ast/, where it
properly belongs.

BUG=v8:5294

Committed: https://crrev.com/6dd2bc20b46f9a9e341b2549c6db6018ffcba448
Cr-Commit-Position: refs/heads/master@{#39141}
==========

[commit-bot: I haz the power, 2016-09-02 17:48:54]

Patchset 3 (id:??) landed as
https://crrev.com/6dd2bc20b46f9a9e341b2549c6db6018ffcba448
Cr-Commit-Position: refs/heads/master@{#39141}

[Michael Starzinger, 2016-09-05 10:57:41]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-09-05 10:57:42]

LGTM.