Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2305873002: cc: Include viewport clip in visible rect of unclipped surfaces (Closed)

Created:
4 years, 3 months ago by jaydasika
Modified:
4 years, 3 months ago
Reviewers:
ajuma, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Include viewport clip in visible rect of unclipped surfaces BUG=642054 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/526eae0ac56bb041ad4304d4e7bfc66853c66e2b Cr-Commit-Position: refs/heads/master@{#416160}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
jaydasika
This is a step towards making use of combined clips for visible rect calculation.
4 years, 3 months ago (2016-09-01 21:41:47 UTC) #3
ajuma
lgtm https://codereview.chromium.org/2305873002/diff/1/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/2305873002/diff/1/cc/trees/layer_tree_host_common_unittest.cc#newcode3342 cc/trees/layer_tree_host_common_unittest.cc:3342: // layers have their drawable content rects clipped ...
4 years, 3 months ago (2016-09-01 23:52:54 UTC) #8
weiliangc
\o/ So happy this is such reasonable sized CL. Thanks for taking this on!
4 years, 3 months ago (2016-09-01 23:57:47 UTC) #9
jaydasika
https://codereview.chromium.org/2305873002/diff/1/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/2305873002/diff/1/cc/trees/layer_tree_host_common_unittest.cc#newcode3342 cc/trees/layer_tree_host_common_unittest.cc:3342: // layers have their drawable content rects clipped by ...
4 years, 3 months ago (2016-09-02 00:38:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305873002/20001
4 years, 3 months ago (2016-09-02 00:38:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 01:48:36 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 01:51:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/526eae0ac56bb041ad4304d4e7bfc66853c66e2b
Cr-Commit-Position: refs/heads/master@{#416160}

Powered by Google App Engine
This is Rietveld 408576698