Apply first-line transform-text style

Apply first-line transform-text style
BUG=129669
Committed: https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658
Cr-Commit-Position: refs/heads/master@{#416608}

[rhogan, 2016-09-01 20:56:31]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 20:57:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:32:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:32:47]

Dry run: This issue passed the CQ dry run.

[rhogan, 2016-09-05 18:00:32]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2016-09-05 18:00:33]

https://codereview.chromium.org/2305833002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutText.cpp (right):

https://codereview.chromium.org/2305833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutText.cpp:1414: case TTNONE:
I decided to not try and adapt the previous function to fit a from/to replace
model. The duplication seems the lesser of two evils.

https://codereview.chromium.org/2305833002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp (right):

https://codereview.chromium.org/2305833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp:129:
toInlineTextBox(child)->transformText();
Ideally we would find the line-break using the transformed text rather than
transforming it after we've established a line-break. This approach might lead
to transformed text poking out over the edge of the container. That would mean a
lot more transforming of text overall - which is not necessarily super-expensive
but maybe this approach is good-enough?

[eae, 2016-09-05 20:53:34]

LGTM

https://codereview.chromium.org/2305833002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutText.cpp (right):

https://codereview.chromium.org/2305833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutText.cpp:1414: case TTNONE:
On 2016/09/05 18:00:33, rhogan wrote:
> I decided to not try and adapt the previous function to fit a from/to replace
> model. The duplication seems the lesser of two evils.

I agree. Thanks for the clarification.

[rhogan, 2016-09-06 07:48:16]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-09-06 07:48:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 09:11:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-06 09:12:36]

Description was changed from

==========
Apply first-line transform-text style
BUG=129669
==========

to

==========
Apply first-line transform-text style
BUG=129669

Committed: https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658
Cr-Commit-Position: refs/heads/master@{#416608}
==========

[commit-bot: I haz the power, 2016-09-06 09:12:37]

Patchset 1 (id:??) landed as
https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658
Cr-Commit-Position: refs/heads/master@{#416608}

[Will Harris, 2016-09-07 22:01:32]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2317303002/ by wfh@chromium.org.

The reason for reverting is: see crbug.com/644733.

[rhogan, 2016-09-09 18:46:25]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 20:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:41:15]

Dry run: This issue passed the CQ dry run.