Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2305723002: local ntp: fix up accessibility tree (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b1f304ae362d2f6e19d1a21bfd69e01b14ef9c74 Cr-Commit-Position: refs/heads/master@{#416617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/local_ntp/most_visited_single.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
Elly Fong-Jones
jered: ptal? :)
4 years, 3 months ago (2016-09-01 18:11:05 UTC) #4
Jered
On 2016/09/01 18:11:05, Elly Jones wrote: > jered: ptal? :) lgtm
4 years, 3 months ago (2016-09-02 00:43:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305723002/1
4 years, 3 months ago (2016-09-02 10:05:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2370)
4 years, 3 months ago (2016-09-02 10:12:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305723002/1
4 years, 3 months ago (2016-09-02 10:22:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2372)
4 years, 3 months ago (2016-09-02 10:29:54 UTC) #13
Elly Fong-Jones
On 2016/09/02 10:29:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-02 11:33:01 UTC) #14
Jered
On 2016/09/02 11:33:01, Elly Jones wrote: > On 2016/09/02 10:29:54, commit-bot: I haz the power ...
4 years, 3 months ago (2016-09-02 21:24:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305723002/1
4 years, 3 months ago (2016-09-06 10:10:38 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 12:09:08 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 12:11:06 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1f304ae362d2f6e19d1a21bfd69e01b14ef9c74
Cr-Commit-Position: refs/heads/master@{#416617}

Powered by Google App Engine
This is Rietveld 408576698