|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Elly Fong-Jones Modified:
4 years, 3 months ago Reviewers:
Jered CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionlocal ntp: fix up accessibility tree
This change:
1) Marks the "don't show this" button in the local NTP as a button
2) Sets an explicit aria-label on NTP "tiles"
BUG=641926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/b1f304ae362d2f6e19d1a21bfd69e01b14ef9c74
Cr-Commit-Position: refs/heads/master@{#416617}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 ========== to ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
ellyjones@chromium.org changed reviewers: + jered@chromium.org
jered: ptal? :)
On 2016/09/01 18:11:05, Elly Jones wrote: > jered: ptal? :) lgtm
The CQ bit was checked by ellyjones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by ellyjones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
On 2016/09/02 10:29:54, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...) jered@: do you happen to know what this bot is? I haven't heard of it before.
On 2016/09/02 11:33:01, Elly Jones wrote: > On 2016/09/02 10:29:54, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...) > > jered@: do you happen to know what this bot is? I haven't heard of it before. sorry nope (still lgtm)
The CQ bit was checked by ellyjones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== local ntp: fix up accessibility tree This change: 1) Marks the "don't show this" button in the local NTP as a button 2) Sets an explicit aria-label on NTP "tiles" BUG=641926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b1f304ae362d2f6e19d1a21bfd69e01b14ef9c74 Cr-Commit-Position: refs/heads/master@{#416617} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b1f304ae362d2f6e19d1a21bfd69e01b14ef9c74 Cr-Commit-Position: refs/heads/master@{#416617} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
