Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2305683002:
DecoderStreamTraits: remove redundant explicit instantiation definitions (Closed)
DescriptionDecoderStreamTraits: remove redundant explicit instantiation definitions
The template was already explicitly specialized with these types in the
header, so the instantiations here have no effect, and recent Clang
versions warn about it.
BUG=643235
R=thakis@chromium.org
TBR=chcunningham
Committed: https://chromium.googlesource.com/chromium/src/+/36676ab3858596d6fa27ffeddd6055f44a8b38cd
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The templte was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 ========== to ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The templte was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 ==========
hans@chromium.org changed reviewers: + chcunningham@chromium.org, thakis@chromium.org
Please take a look. See the bug for Clang's warning message.
The CQ bit was checked by hans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The templte was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 ========== to ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 ==========
lgtm
Description was changed from ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 ========== to ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 TBR=chcunningham ==========
lgtm
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 TBR=chcunningham ========== to ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 R=thakis@chromium.org TBR=chcunningham Committed: https://crrev.com/36676ab3858596d6fa27ffeddd6055f44a8b38cd Cr-Commit-Position: refs/heads/master@{#415999} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/36676ab3858596d6fa27ffeddd6055f44a8b38cd Cr-Commit-Position: refs/heads/master@{#415999}
Message was sent while issue was closed.
Description was changed from ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 R=thakis@chromium.org TBR=chcunningham Committed: https://crrev.com/36676ab3858596d6fa27ffeddd6055f44a8b38cd Cr-Commit-Position: refs/heads/master@{#415999} ========== to ========== DecoderStreamTraits: remove redundant explicit instantiation definitions The template was already explicitly specialized with these types in the header, so the instantiations here have no effect, and recent Clang versions warn about it. BUG=643235 R=thakis@chromium.org TBR=chcunningham Committed: https://chromium.googlesource.com/chromium/src/+/36676ab3858596d6fa27ffeddd60... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 36676ab3858596d6fa27ffeddd6055f44a8b38cd (presubmit successful). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
