Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2305623004: Refactor how we read global-type-inference data from ssa (Closed)

Created:
4 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix copy/paste typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -123 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 24 chunks +49 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 4 chunks +99 lines, -54 lines 0 comments Download
M tests/compiler/dart2js/arithmetic_simplification_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2305623004/diff/60001/pkg/compiler/lib/src/ssa/types.dart File pkg/compiler/lib/src/ssa/types.dart (left): https://codereview.chromium.org/2305623004/diff/60001/pkg/compiler/lib/src/ssa/types.dart#oldcode33 pkg/compiler/lib/src/ssa/types.dart:33: static TypeMask inferredForNode( this became "_inferredTypeOfNewList" in ssa/builder.dart The ...
4 years, 3 months ago (2016-09-02 20:24:17 UTC) #5
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-02 20:31:53 UTC) #6
Harry Terkelsen
lgtm nice!
4 years, 3 months ago (2016-09-02 20:40:08 UTC) #7
Siggi Cherem (dart-lang)
Committed patchset #1 (id:60001) manually as a319239145fc65ba237489061f1a173fc42914f9 (presubmit successful).
4 years, 3 months ago (2016-09-02 23:24:48 UTC) #10
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-06 16:07:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:100001) manually as
2503bab2549c63df6ff2eb4ad48d6f660b1a88c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698