Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 2305603002: [Worker] Call contextDestroyed in shutdown preparation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
index 55ad091a54ccf1baa29fcba78dbd20b35ff2b287..545efcef7cff5891a8665a58356f24684504ed8b 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
@@ -579,6 +579,7 @@ void WorkerThread::prepareForShutdownOnWorkerThread()
m_workerInspectorController->dispose();
m_workerInspectorController.clear();
}
+ globalScope()->notifyContextDestroyed();
m_consoleMessageStorage.clear();
workerBackingThread().backingThread().removeTaskObserver(m_microtaskRunner.get());
}
@@ -599,7 +600,6 @@ void WorkerThread::performShutdownOnWorkerThread()
// because no other thread will run GC or otherwise destroy them. If Oilpan
// is enabled, we detach of the context/global scope, with the final heap
// cleanup below sweeping it out.
- globalScope()->notifyContextDestroyed();
m_globalScope = nullptr;
if (isOwningBackingThread())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698