Issue 23056005: Nobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23056005: Nobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it. (Closed)

Created:
7 years, 4 months ago by mtklein

Modified:
7 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Nobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it. I left the dummy value in the flattened paint. I'm hoping to do an overhaul of the paint serialization format which will need a picture version bump anyway, so it can all go together. If that doesn't pan out we can remove this on its own later. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10757

Patch Set 1 #

Patch Set 2 : undo #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -77 lines)			Patch
M	gyp/common_conditions.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkPaint.h	View		2 chunks	+0 lines, -17 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	1	7 chunks	+2 lines, -31 lines	0 comments	Download
M	src/core/SkScalerContext.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View		1 chunk	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

assuming we've confirmed that Android also doesn't ever set this... lgtm

7 years, 4 months ago (2013-08-14 15:29:21 UTC) #2

mtklein

7 years, 4 months ago (2013-08-15 21:20:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r10757 (presubmit successful).

Expand Messages | Collapse Messages