Move congruent type variables optimization out of builder into simplifier

Move congruent type variables optimization out of builder into simplifier

BUG=
R=het@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9477f7e1e267e3bdb82287c9cccf903cbbc011a3

[sra1, 2016-09-02 17:44:40]

Patchset #1 (id:1) has been deleted

[sra1, 2016-09-02 17:44:47]

Patchset #1 (id:20001) has been deleted

[sra1, 2016-09-02 17:53:04]

sra@google.com changed reviewers:
+ het@google.com, sigmund@google.com

[sra1, 2016-09-02 17:53:05]

Harry: removing code from the builder should make your life slightly easier.

[Siggi Cherem (dart-lang), 2016-09-02 18:02:29]

lgtm

https://codereview.chromium.org/2305583005/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2305583005/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:1088: // Fall-through for unrecognized
argument.
nit: I might prefer to remove the "continue" above and write it as:

if (argument isHTypeInfoReadVariable) {
  ...
} else {
  return null;
}

[Harry Terkelsen, 2016-09-02 18:04:51]

lgtm

[sra1, 2016-09-02 18:23:14]

https://codereview.chromium.org/2305583005/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2305583005/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:1088: // Fall-through for unrecognized
argument.
On 2016/09/02 18:02:29, Siggi Cherem (dart-lang) wrote:
> nit: I might prefer to remove the "continue" above and write it as:
> 
> if (argument isHTypeInfoReadVariable) {
>   ...
> } else {
>   return null;
> }

Done.

[sra1, 2016-09-02 18:50:59]

Description was changed from

==========
Move congruent type variables optimization out of builder into simplifier

BUG=
==========

to

==========
Move congruent type variables optimization out of builder into simplifier

BUG=
R=het@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9477f7e1e267e3bdb82287c9cccf903cbbc011a3
==========

[sra1, 2016-09-02 18:51:00]

Committed patchset #2 (id:60001) manually as
9477f7e1e267e3bdb82287c9cccf903cbbc011a3 (presubmit successful).