Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2305583003: File manager: Fix PIEX_LOADER resource defintions. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
hirono, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

File manager: Fix PIEX_LOADER resource defintions. image_loader/piex/piex.pexe.txt should be included in official builds, since image_loader/piex/piex.nmf.txt references it. BUG=642924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M ui/file_manager/file_manager_resources.grd View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Lei Zhang
FWWIW, https://crrev.com/322372 originally added this snippet.
4 years, 3 months ago (2016-09-01 18:38:35 UTC) #4
hirono
Hi, thank you for fixing the grd file. We also need a fix in the ...
4 years, 3 months ago (2016-09-02 00:11:30 UTC) #7
Lei Zhang
On 2016/09/02 00:11:30, hirono wrote: > Hi, thank you for fixing the grd file. We ...
4 years, 3 months ago (2016-09-02 00:45:44 UTC) #8
fukino
Thank you Lei for investigating this issue so quickly!
4 years, 3 months ago (2016-09-02 01:06:43 UTC) #9
hirono
On 2016/09/02 01:06:43, fukino wrote: > Thank you Lei for investigating this issue so quickly! ...
4 years, 3 months ago (2016-09-02 05:15:32 UTC) #10
Lei Zhang
4 years, 3 months ago (2016-09-02 21:17:18 UTC) #12
Message was sent while issue was closed.
Closing this for now since it may not be needed anymore.

Powered by Google App Engine
This is Rietveld 408576698