Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2305533002:
MD Settings: Reset scroll when sliding subpages (Closed)
|
Created:
4 years, 3 months ago by michaelpg Modified:
4 years, 3 months ago Reviewers:
dschuyler CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Reset scroll when sliding subpages
When navigating from one subpage to another in the same section (sliding
settings-animated-pages), we should scroll to top so different-height cards
don't result in glitches or empty space.
BUG=641930
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/e6b0168feb6dca854ac181a1daf43b1d27c9d4e8
Cr-Commit-Position: refs/heads/master@{#416844}
Patch Set 1 #Patch Set 2 : fix infinite loop (edit: changed and move to own patch) #Patch Set 3 : rebase #Patch Set 4 : rebase #Messages
Total messages: 20 (11 generated)
Description was changed from ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org ========== to ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. Also, pages that are not shown (but have been stamped) enter an infinite setInterval loop when another page slides to a subpage. Fix that too. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. Also, pages that are not shown (but have been stamped) enter an infinite setInterval loop when another page slides to a subpage. Fix that too. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org Link to the patchset: https://codereview.chromium.org/2305533002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG=641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e6b0168feb6dca854ac181a1daf43b1d27c9d4e8 Cr-Commit-Position: refs/heads/master@{#416844} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e6b0168feb6dca854ac181a1daf43b1d27c9d4e8 Cr-Commit-Position: refs/heads/master@{#416844} |
