ARM64: Access has_pending_message_ correctly.

src/arm64/full-codegen-arm64.cc

Index: src/arm64/full-codegen-arm64.cc
diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc
index 819868b5d855af8c15eb13f87a35e067d47625ec..fe7c6c74cfbfa46a4096ba2a5a7a5e2b8969438c 100644
--- a/src/arm64/full-codegen-arm64.cc
+++ b/src/arm64/full-codegen-arm64.cc
@@ -4820,8 +4820,9 @@ void FullCodeGenerator::EnterFinallyBlock() {
 
   ExternalReference has_pending_message =
       ExternalReference::address_of_has_pending_message(isolate());
+  STATIC_ASSERT(sizeof(bool) == 1);   // NOLINT(runtime/sizeof)
   __ Mov(x11, has_pending_message);
-  __ Ldr(x11, MemOperand(x11));
+  __ Ldrb(x11, MemOperand(x11));
   __ SmiTag(x11);
 
   __ Push(x10, x11);
@@ -4849,7 +4850,8 @@ void FullCodeGenerator::ExitFinallyBlock() {
   ExternalReference has_pending_message =
       ExternalReference::address_of_has_pending_message(isolate());
   __ Mov(x13, has_pending_message);
-  __ Str(x11, MemOperand(x13));
+  STATIC_ASSERT(sizeof(bool) == 1);   // NOLINT(runtime/sizeof)

[jbramley, 2014/04/09 13:41:12]

This is defined in the ABI for both ARM and AArch64. It's also true for the
simulator host environments I tested (gcc 4.8.1 on Ubuntu 13.10). If it causes
trouble, we'll have to review how we handle accesses to fields where the size is
determined by the host environment. We might need templated Ldr/Str variants to
load host data types, for example.

[ulan, 2014/04/09 13:51:47]

Another solution would be to change the type of "has_pending_message" to
something platform-independent, like int8_t or int32_t. Jochen, wdyt?

+  __ Strb(x11, MemOperand(x13));
 
   ExternalReference pending_message_obj =
       ExternalReference::address_of_pending_message_obj(isolate());