Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 230553004: ARM64: Access has_pending_message_ correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/arm64/full-codegen-arm64.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4748 matching lines...) Expand 10 before | Expand all | Expand 10 after
4759 // Store pending message while executing finally block. 4759 // Store pending message while executing finally block.
4760 ExternalReference pending_message_obj = 4760 ExternalReference pending_message_obj =
4761 ExternalReference::address_of_pending_message_obj(isolate()); 4761 ExternalReference::address_of_pending_message_obj(isolate());
4762 __ mov(ip, Operand(pending_message_obj)); 4762 __ mov(ip, Operand(pending_message_obj));
4763 __ ldr(r1, MemOperand(ip)); 4763 __ ldr(r1, MemOperand(ip));
4764 __ push(r1); 4764 __ push(r1);
4765 4765
4766 ExternalReference has_pending_message = 4766 ExternalReference has_pending_message =
4767 ExternalReference::address_of_has_pending_message(isolate()); 4767 ExternalReference::address_of_has_pending_message(isolate());
4768 __ mov(ip, Operand(has_pending_message)); 4768 __ mov(ip, Operand(has_pending_message));
4769 __ ldr(r1, MemOperand(ip)); 4769 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
4770 __ ldrb(r1, MemOperand(ip));
4770 __ SmiTag(r1); 4771 __ SmiTag(r1);
4771 __ push(r1); 4772 __ push(r1);
4772 4773
4773 ExternalReference pending_message_script = 4774 ExternalReference pending_message_script =
4774 ExternalReference::address_of_pending_message_script(isolate()); 4775 ExternalReference::address_of_pending_message_script(isolate());
4775 __ mov(ip, Operand(pending_message_script)); 4776 __ mov(ip, Operand(pending_message_script));
4776 __ ldr(r1, MemOperand(ip)); 4777 __ ldr(r1, MemOperand(ip));
4777 __ push(r1); 4778 __ push(r1);
4778 } 4779 }
4779 4780
4780 4781
4781 void FullCodeGenerator::ExitFinallyBlock() { 4782 void FullCodeGenerator::ExitFinallyBlock() {
4782 ASSERT(!result_register().is(r1)); 4783 ASSERT(!result_register().is(r1));
4783 // Restore pending message from stack. 4784 // Restore pending message from stack.
4784 __ pop(r1); 4785 __ pop(r1);
4785 ExternalReference pending_message_script = 4786 ExternalReference pending_message_script =
4786 ExternalReference::address_of_pending_message_script(isolate()); 4787 ExternalReference::address_of_pending_message_script(isolate());
4787 __ mov(ip, Operand(pending_message_script)); 4788 __ mov(ip, Operand(pending_message_script));
4788 __ str(r1, MemOperand(ip)); 4789 __ str(r1, MemOperand(ip));
4789 4790
4790 __ pop(r1); 4791 __ pop(r1);
4791 __ SmiUntag(r1); 4792 __ SmiUntag(r1);
4792 ExternalReference has_pending_message = 4793 ExternalReference has_pending_message =
4793 ExternalReference::address_of_has_pending_message(isolate()); 4794 ExternalReference::address_of_has_pending_message(isolate());
4794 __ mov(ip, Operand(has_pending_message)); 4795 __ mov(ip, Operand(has_pending_message));
4795 __ str(r1, MemOperand(ip)); 4796 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
4797 __ strb(r1, MemOperand(ip));
4796 4798
4797 __ pop(r1); 4799 __ pop(r1);
4798 ExternalReference pending_message_obj = 4800 ExternalReference pending_message_obj =
4799 ExternalReference::address_of_pending_message_obj(isolate()); 4801 ExternalReference::address_of_pending_message_obj(isolate());
4800 __ mov(ip, Operand(pending_message_obj)); 4802 __ mov(ip, Operand(pending_message_obj));
4801 __ str(r1, MemOperand(ip)); 4803 __ str(r1, MemOperand(ip));
4802 4804
4803 // Restore result register from stack. 4805 // Restore result register from stack.
4804 __ pop(r1); 4806 __ pop(r1);
4805 4807
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
4929 4931
4930 ASSERT(interrupt_address == 4932 ASSERT(interrupt_address ==
4931 isolate->builtins()->OsrAfterStackCheck()->entry()); 4933 isolate->builtins()->OsrAfterStackCheck()->entry());
4932 return OSR_AFTER_STACK_CHECK; 4934 return OSR_AFTER_STACK_CHECK;
4933 } 4935 }
4934 4936
4935 4937
4936 } } // namespace v8::internal 4938 } } // namespace v8::internal
4937 4939
4938 #endif // V8_TARGET_ARCH_ARM 4940 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/arm64/full-codegen-arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698