Chromium Code Reviews

Issue 230553003: Remove ConfigureDefaults version that does not take the amount of virtual mem (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
dcarney, Paweł Hajdan Jr.
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove ConfigureDefaults version that does not take the amount of virtual mem R=dcarney@chromium.org LOG=n BUG=none Committed: https://code.google.com/p/v8/source/detail?r=20702

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Stats (+0 lines, -5 lines)
M include/v8.h View 1 chunk +0 lines, -5 lines 3 comments

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-09 12:50:01 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-09 12:57:42 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r20702 (presubmit successful).
6 years, 8 months ago (2014-04-14 06:55:48 UTC) #3
Paweł Hajdan Jr.
Drive-by with a question. https://codereview.chromium.org/230553003/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/230553003/diff/1/include/v8.h#oldcode3962 include/v8.h:3962: // Deprecated. Wait, this did ...
6 years, 8 months ago (2014-04-17 14:16:24 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/230553003/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/230553003/diff/1/include/v8.h#oldcode3962 include/v8.h:3962: // Deprecated. On 2014/04/17 14:16:24, Paweł Hajdan Jr. wrote: ...
6 years, 8 months ago (2014-04-17 14:20:31 UTC) #5
Paweł Hajdan Jr.
https://codereview.chromium.org/230553003/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/230553003/diff/1/include/v8.h#oldcode3962 include/v8.h:3962: // Deprecated. On 2014/04/17 14:20:31, jochen wrote: > On ...
6 years, 7 months ago (2014-04-28 12:21:10 UTC) #6
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-04-28 12:58:08 UTC) #7
Message was sent while issue was closed. 
On 2014/04/28 12:21:10, Paweł Hajdan Jr. wrote:
> https://codereview.chromium.org/230553003/diff/1/include/v8.h
> File include/v8.h (left):
> 
> https://codereview.chromium.org/230553003/diff/1/include/v8.h#oldcode3962
> include/v8.h:3962: // Deprecated.
> On 2014/04/17 14:20:31, jochen wrote:
> > On 2014/04/17 14:16:24, Paweł Hajdan Jr. wrote:
> > > Wait, this did not get through V8_DEPRECATED process. Is that really OK?
> > 
> > There is no such process.
> 
> I'm surprised by this, could you explain more?
> 
> I can understand starting with just a // Deprecated comment as opposed to
> V8_DEPRECATED so that Chromium can compile.
> 
> But then it seems the course of action would be to use V8_DEPRECATED rather
than
> removing the API immediately.

Sure, but I won't keep unused code around, and as far as I can tell, nobody but
chrome uses it.

Powered by Google App Engine