Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2305523002: [parser] Clean up ParserBase typedefs (Closed)

Created:
4 years, 3 months ago by bakkot
Modified:
4 years, 3 months ago
Reviewers:
nickie, Dan Ehrenberg, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Clean up ParserBase typedefs The ParserTypes class has typedefs provided by the preparser or the parser (e.g. PreParserExpression vs Expression*). Some of those typedefs had gotten stale and were getting in the way, especially on gcc. We also were making inconsistent use of aliases in parser-base.h; now their use is much more consistent. Committed: https://crrev.com/5c8c6fa160374d393c1d5575300c876b97332949 Cr-Commit-Position: refs/heads/master@{#39101}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : document Block typedef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -38 lines) Patch
M src/parsing/parser.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 10 chunks +20 lines, -26 lines 0 comments Download
M src/parsing/preparser.h View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
bakkot
PTAL. I'm not sure what the source of these typedefs was, but removing them doesn't ...
4 years, 3 months ago (2016-09-01 01:18:57 UTC) #9
marja
lgtm. Probably these were needed in some previous state but not anymore. Thanks for the ...
4 years, 3 months ago (2016-09-01 07:34:32 UTC) #10
nickie
lgtm
4 years, 3 months ago (2016-09-01 10:25:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305523002/40001
4 years, 3 months ago (2016-09-01 18:23:51 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 18:26:11 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 18:26:51 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5c8c6fa160374d393c1d5575300c876b97332949
Cr-Commit-Position: refs/heads/master@{#39101}

Powered by Google App Engine
This is Rietveld 408576698