Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2305513003: Allow QUIC servers send a TTL for the server config, as opposed to explicit expiration, to mitigate… (Closed)

Created:
4 years, 3 months ago by Victor Vasiliev
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow QUIC servers send a TTL for the server config, as opposed to explicit expiration, to mitigate client clock skew. Protected by enabled --quic_send_scfg_ttl. Merge internal change: 131052582 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Allow QUIC servers send a TTL for the server config, as opposed to explicit expiration, to mitigate… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -22 lines) Patch
M net/quic/chromium/quic_stream_factory.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 6 chunks +22 lines, -8 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 3 chunks +29 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 7 chunks +23 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 5 chunks +23 lines, -5 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Victor Vasiliev
4 years, 3 months ago (2016-09-01 17:29:02 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-01 18:03:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698