Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2305513002: MD Settings: Fix input label spacing (Closed)

Created:
4 years, 3 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix input label spacing In https://codereview.chromium.org/2224613003 I changed how settings-dropdown-menu worked; in the process I accidentally an attribute on an unrelated settings-input. BUG=642643 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c80e40aa9092c5980b86265da5620a299cc06fc1 Cr-Commit-Position: refs/heads/master@{#416036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
michaelpg
4 years, 3 months ago (2016-09-01 00:29:19 UTC) #2
stevenjb
lgtm
4 years, 3 months ago (2016-09-01 15:53:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305513002/1
4 years, 3 months ago (2016-09-01 18:07:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 20:34:14 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:36:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c80e40aa9092c5980b86265da5620a299cc06fc1
Cr-Commit-Position: refs/heads/master@{#416036}

Powered by Google App Engine
This is Rietveld 408576698