Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Side by Side Diff: runtime/vm/isolate.cc

Issue 2305493002: Address additional comments re class id sorting. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/class_table.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/isolate.h" 5 #include "vm/isolate.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/text_buffer.h" 10 #include "platform/text_buffer.h"
(...skipping 1867 matching lines...) Expand 10 before | Expand all | Expand 10 after
1878 #ifndef PRODUCT 1878 #ifndef PRODUCT
1879 if (IsReloading()) { 1879 if (IsReloading()) {
1880 raw_class = reload_context()->GetClassForHeapWalkAt(cid); 1880 raw_class = reload_context()->GetClassForHeapWalkAt(cid);
1881 } else { 1881 } else {
1882 raw_class = class_table()->At(cid); 1882 raw_class = class_table()->At(cid);
1883 } 1883 }
1884 #else 1884 #else
1885 raw_class = class_table()->At(cid); 1885 raw_class = class_table()->At(cid);
1886 #endif // !PRODUCT 1886 #endif // !PRODUCT
1887 ASSERT(raw_class != NULL); 1887 ASSERT(raw_class != NULL);
1888 #if !defined(DART_PRECOMPILER)
1888 // This is temporarily untrue during a class id remap. 1889 // This is temporarily untrue during a class id remap.
1889 // ASSERT(raw_class->ptr()->id_ == cid); 1890 ASSERT(raw_class->ptr()->id_ == cid);
1891 #endif
1890 return raw_class; 1892 return raw_class;
1891 } 1893 }
1892 1894
1893 1895
1894 #ifndef PRODUCT 1896 #ifndef PRODUCT
1895 static const char* ExceptionPauseInfoToServiceEnum(Dart_ExceptionPauseInfo pi) { 1897 static const char* ExceptionPauseInfoToServiceEnum(Dart_ExceptionPauseInfo pi) {
1896 switch (pi) { 1898 switch (pi) {
1897 case kPauseOnAllExceptions: 1899 case kPauseOnAllExceptions:
1898 return "All"; 1900 return "All";
1899 case kNoPauseOnExceptions: 1901 case kNoPauseOnExceptions:
(...skipping 991 matching lines...) Expand 10 before | Expand all | Expand 10 after
2891 void IsolateSpawnState::DecrementSpawnCount() { 2893 void IsolateSpawnState::DecrementSpawnCount() {
2892 ASSERT(spawn_count_monitor_ != NULL); 2894 ASSERT(spawn_count_monitor_ != NULL);
2893 ASSERT(spawn_count_ != NULL); 2895 ASSERT(spawn_count_ != NULL);
2894 MonitorLocker ml(spawn_count_monitor_); 2896 MonitorLocker ml(spawn_count_monitor_);
2895 ASSERT(*spawn_count_ > 0); 2897 ASSERT(*spawn_count_ > 0);
2896 *spawn_count_ = *spawn_count_ - 1; 2898 *spawn_count_ = *spawn_count_ - 1;
2897 ml.Notify(); 2899 ml.Notify();
2898 } 2900 }
2899 2901
2900 } // namespace dart 2902 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/class_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698