Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2305453002: Remove unnecessary hide clauses (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/watch_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/sdk_ext.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/bazel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/incremental_cache.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/pub_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/embedder_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
It appears that the class Resource has been removed from the SDK so it is ...
4 years, 3 months ago (2016-08-31 23:41:49 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-08-31 23:43:33 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-08-31 23:44:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2cdafd82c2c2c18dd505a5e3d3a17c9efb0fb4a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698