Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2305433003: Revert of Disallow non-namespaced use of base::Version. (Closed)

Created:
4 years, 3 months ago by battre
Modified:
4 years, 3 months ago
Reviewers:
Nico, pwnall
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disallow non-namespaced use of base::Version. (patchset #2 id:20001 of https://codereview.chromium.org/2290173006/ ) Reason for revert: Breaks Google Chrome Linux x64 builder, see http://crbug.com/639416#c16 Original issue's description: > Disallow non-namespaced use of base::Version. > > This is a reland of > https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 > > BUG=639416 > > Committed: https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0 > Cr-Commit-Position: refs/heads/master@{#415940} TBR=thakis@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639416 Committed: https://crrev.com/eae359bdbd66abae7461dcb12e5026b4dfc8e7ea Cr-Commit-Position: refs/heads/master@{#415946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M base/version.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
battre
Created Revert of Disallow non-namespaced use of base::Version.
4 years, 3 months ago (2016-09-01 14:21:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305433003/1
4 years, 3 months ago (2016-09-01 14:22:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 14:23:03 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 14:24:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eae359bdbd66abae7461dcb12e5026b4dfc8e7ea
Cr-Commit-Position: refs/heads/master@{#415946}

Powered by Google App Engine
This is Rietveld 408576698