Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2305373002: Revert of includes: Make ast.h not need isolate.h any more. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of includes: Make ast.h not need isolate.h any more. (patchset #3 id:60001 of https://codereview.chromium.org/2301423002/ ) Reason for revert: Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/5642 Original issue's description: > includes: Make ast.h not need isolate.h any more. > > Also remove other unnecessary includes from ast.h and dependencies. > > BUG=v8:5294 > > Committed: https://crrev.com/9c888dffda4bff420ec3ef21e623aa4e5054d1c3 > Cr-Commit-Position: refs/heads/master@{#39155} TBR=adamk@chromium.org,mstarzinger@chromium.org,bmeurer@chromium.org,marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5294 Committed: https://crrev.com/ab1d4cdac4959c49913a80fd727d3932e04bb456 Cr-Commit-Position: refs/heads/master@{#39159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -26 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/ast.h View 4 chunks +12 lines, -1 line 0 comments Download
M src/ast/ast-expression-rewriter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ast/ast-numbering.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/ast/ast-traversal-visitor.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/ast/modules.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/ast/modules.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/prettyprinter.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/typing.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/debug/liveedit.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/parsing/rewriter.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of includes: Make ast.h not need isolate.h any more.
4 years, 3 months ago (2016-09-05 11:48:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305373002/1
4 years, 3 months ago (2016-09-05 11:48:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 11:49:01 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 11:49:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab1d4cdac4959c49913a80fd727d3932e04bb456
Cr-Commit-Position: refs/heads/master@{#39159}

Powered by Google App Engine
This is Rietveld 408576698