Issue 230533002: Add tests for leak errors

Issue 230533002: Add tests for leak errors (Closed)

Created:
6 years, 8 months ago by hajimehoshi

Modified:
6 years, 8 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add tests for leak errors BUG=332630 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171464

Patch Set 2 : #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -8 lines)			Patch
M	Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py	View	7 chunks	+12 lines, -4 lines	2 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/test.py	View	6 chunks	+9 lines, -4 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm assuming the timout change noted below isn't a bug ... https://codereview.chromium.org/230533002/diff/40001/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py File Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py (right): ...

6 years, 8 months ago (2014-04-09 16:11:51 UTC) #2

hajimehoshi

Thank you! https://codereview.chromium.org/230533002/diff/40001/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py File Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py (right): https://codereview.chromium.org/230533002/diff/40001/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py#newcode135 Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:135: self.assertEquals(summary['num_failures_by_type'], {'CRASH': 1, 'MISSING': 0, 'TEXT': 0, ...

6 years, 8 months ago (2014-04-10 02:08:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/230533002/40001

6 years, 8 months ago (2014-04-11 02:08:44 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/230533002/40001

6 years, 8 months ago (2014-04-11 23:54:17 UTC) #6

Message was sent while issue was closed.

Change committed as 171464

Expand Messages | Collapse Messages