Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2305323002: Initialize mojo once in non-SFI NaCl. (Closed)

Created:
4 years, 3 months ago by Sam McNally
Modified:
4 years, 3 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize mojo once in non-SFI NaCl. Previously, mojo::edk::Init() was called twice for non-SFI NaCl: once during loader init and once during plugin startup. This moves the second Init() call to the other user of StartUpPlugin() that does require an Init() call: nacl_irt_start(). BUG=604282 Committed: https://crrev.com/a6ae9626e1d8474ec01b17002ec4186878a973d0 Cr-Commit-Position: refs/heads/master@{#416601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M ppapi/nacl_irt/irt_start.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/nacl_irt/plugin_startup.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Sam McNally
4 years, 3 months ago (2016-09-05 07:06:38 UTC) #7
Mark Seaborn
LGTM
4 years, 3 months ago (2016-09-06 05:48:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305323002/1
4 years, 3 months ago (2016-09-06 06:56:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 07:31:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 07:33:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6ae9626e1d8474ec01b17002ec4186878a973d0
Cr-Commit-Position: refs/heads/master@{#416601}

Powered by Google App Engine
This is Rietveld 408576698