Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2305213002: Only allow VR presentation in response to a user gesture (Closed)

Created:
4 years, 3 months ago by bajones
Modified:
4 years, 3 months ago
Reviewers:
girard
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only allow VR presentation in response to a user gesture BUG=389343 Committed: https://crrev.com/92370143e6206f3bffe3e9bac1618c840f22648b Cr-Commit-Position: refs/heads/master@{#416473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 4 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bajones
Yes, it's a US/CAN holiday weekend. I don't expect prompt reviews. :) Just need a ...
4 years, 3 months ago (2016-09-03 20:05:39 UTC) #2
girard
LGTM
4 years, 3 months ago (2016-09-04 12:07:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305213002/1
4 years, 3 months ago (2016-09-04 15:38:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-04 15:41:42 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 15:43:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92370143e6206f3bffe3e9bac1618c840f22648b
Cr-Commit-Position: refs/heads/master@{#416473}

Powered by Google App Engine
This is Rietveld 408576698