chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java - Issue 2305123002: [Downloads UI] Batch delete selected items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Issue 2305123002: [Downloads UI] Batch delete selected items (Closed)

Patch Set: foreach Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/FileUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

index 018331613b6394da7e0de5ea6980aaa0fea667b4..1a7309334df4fc7c36250e73a09f32d237053b1b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

@@ -455,7 +455,7 @@ public class DownloadHistoryAdapter extends DateDividedAdapter implements Downlo

private void removeExternallyDeletedItem(DownloadItemWrapper wrapper, boolean isOffTheRecord) {

getExternallyDeletedItemsMap(isOffTheRecord).put(wrapper.getId(), true);

- wrapper.delete(null);

+ wrapper.remove();

RecordUserAction.record("Android.DownloadManager.Item.ExternallyDeleted");

}