Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/renderer.h

Issue 2305113002: Make default media::Renderer::playback_rate = 0. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromecast/media/cma/pipeline/media_pipeline_impl.cc ('K') | « chromecast/media/cma/pipeline/media_pipeline_impl.cc ('k') | media/base/time_delta_interpolator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/renderer.h
diff --git a/media/base/renderer.h b/media/base/renderer.h
index fae6115f3c8ee619eb1efa3da7c4195b40244cd3..190cc380a38f977c1bc28d81be87090829a06036 100644
--- a/media/base/renderer.h
+++ b/media/base/renderer.h
@@ -49,7 +49,7 @@ class MEDIA_EXPORT Renderer {
// Starts rendering from |time|.
virtual void StartPlayingFrom(base::TimeDelta time) = 0;
- // Updates the current playback rate. The default playback rate should be 1.
alokp 2016/09/02 21:52:38 This comment is inconsistent with that used in Pip
DaleCurtis 2016/09/06 19:15:36 Not sure, whichever one works? :) Defaulting to ze
alokp 2016/09/06 19:26:34 Acknowledged.
+ // Updates the current playback rate. The default playback rate should be 0.
virtual void SetPlaybackRate(double playback_rate) = 0;
// Sets the output volume. The default volume should be 1.
« chromecast/media/cma/pipeline/media_pipeline_impl.cc ('K') | « chromecast/media/cma/pipeline/media_pipeline_impl.cc ('k') | media/base/time_delta_interpolator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698