Make default media::Renderer::playback_rate = 0.

Make default media::Renderer::playback_rate = 0.

BUG=616959
Committed: https://crrev.com/fb5961572eabfc98de77337a52ae4c0be2fef1ed
Cr-Commit-Position: refs/heads/master@{#416997}

[alokp, 2016-09-02 21:52:37]

alokp@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[alokp, 2016-09-02 21:52:38]

https://codereview.chromium.org/2305113002/diff/1/media/base/renderer.h
File media/base/renderer.h (left):

https://codereview.chromium.org/2305113002/diff/1/media/base/renderer.h#oldco...
media/base/renderer.h:52: // Updates the current playback rate. The default
playback rate should be 1.
This comment is inconsistent with that used in PipelineImpl/RendererImpl:
https://cs.chromium.org/chromium/src/media/base/pipeline_impl.cc?dr=Ss&sq=pac...

Which one is correct?

[DaleCurtis, 2016-09-06 19:15:37]

I think defaulting to zero everywhere is fine lgtm.

https://codereview.chromium.org/2305113002/diff/1/chromecast/media/cma/pipeli...
File chromecast/media/cma/pipeline/media_pipeline_impl.cc (right):

https://codereview.chromium.org/2305113002/diff/1/chromecast/media/cma/pipeli...
chromecast/media/cma/pipeline/media_pipeline_impl.cc:86: playback_rate_(0.0f),
Just 0 is fine.

https://codereview.chromium.org/2305113002/diff/1/media/base/renderer.h
File media/base/renderer.h (left):

https://codereview.chromium.org/2305113002/diff/1/media/base/renderer.h#oldco...
media/base/renderer.h:52: // Updates the current playback rate. The default
playback rate should be 1.
On 2016/09/02 at 21:52:38, alokp wrote:
> This comment is inconsistent with that used in PipelineImpl/RendererImpl:
>
https://cs.chromium.org/chromium/src/media/base/pipeline_impl.cc?dr=Ss&sq=pac...
> 
> Which one is correct?

Not sure, whichever one works? :) Defaulting to zero means paused = true.

[alokp, 2016-09-06 19:26:34]

https://codereview.chromium.org/2305113002/diff/1/chromecast/media/cma/pipeli...
File chromecast/media/cma/pipeline/media_pipeline_impl.cc (right):

https://codereview.chromium.org/2305113002/diff/1/chromecast/media/cma/pipeli...
chromecast/media/cma/pipeline/media_pipeline_impl.cc:86: playback_rate_(0.0f),
On 2016/09/06 19:15:36, DaleCurtis wrote:
> Just 0 is fine.

Done.

https://codereview.chromium.org/2305113002/diff/1/media/base/renderer.h
File media/base/renderer.h (left):

https://codereview.chromium.org/2305113002/diff/1/media/base/renderer.h#oldco...
media/base/renderer.h:52: // Updates the current playback rate. The default
playback rate should be 1.
On 2016/09/06 19:15:36, DaleCurtis wrote:
> On 2016/09/02 at 21:52:38, alokp wrote:
> > This comment is inconsistent with that used in PipelineImpl/RendererImpl:
> >
>
https://cs.chromium.org/chromium/src/media/base/pipeline_impl.cc?dr=Ss&sq=pac...
> > 
> > Which one is correct?
> 
> Not sure, whichever one works? :) Defaulting to zero means paused = true.

Acknowledged.

[alokp, 2016-09-06 19:26:38]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-09-06 19:26:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2305113002/#ps20001
(title: "rebase + comments")

[commit-bot: I haz the power, 2016-09-06 19:27:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 19:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 19:49:56]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-09-06 20:14:24]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-09-06 20:14:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2305113002/#ps40001
(title: "fixes cast_media_unittests")

[commit-bot: I haz the power, 2016-09-06 20:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:55:48]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[alokp, 2016-09-07 16:23:58]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-09-07 16:23:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2305113002/#ps60001
(title: "fixes MediaSourcePlayerTest")

[commit-bot: I haz the power, 2016-09-07 16:24:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 18:12:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-07 18:15:11]

Description was changed from

==========
Make default media::Renderer::playback_rate = 0.

BUG=616959
==========

to

==========
Make default media::Renderer::playback_rate = 0.

BUG=616959

Committed: https://crrev.com/fb5961572eabfc98de77337a52ae4c0be2fef1ed
Cr-Commit-Position: refs/heads/master@{#416997}
==========

[commit-bot: I haz the power, 2016-09-07 18:15:12]

Patchset 4 (id:??) landed as
https://crrev.com/fb5961572eabfc98de77337a52ae4c0be2fef1ed
Cr-Commit-Position: refs/heads/master@{#416997}