fpdfsdk/fxedit/fxet_edit.cpp - Issue 2305103002: Make CPDF_Path have a CFX_Path rather than inheriting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fxedit/fxet_edit.cpp

Issue 2305103002: Make CPDF_Path have a CFX_Path rather than inheriting (Closed)

Patch Set: Move to .cpp Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fxedit/fxet_edit.cpp

diff --git a/fpdfsdk/fxedit/fxet_edit.cpp b/fpdfsdk/fxedit/fxet_edit.cpp

index 098ef7f10bf362a06325a1cb4a8b4467d438540d..7d207a83caaee26fc8eb5ac3cf3001cd8f659efe 100644

--- a/fpdfsdk/fxedit/fxet_edit.cpp

+++ b/fpdfsdk/fxedit/fxet_edit.cpp

@@ -137,8 +137,8 @@ void AddRectToPageObjects(CPDF_PageObjectHolder* pObjectHolder,

FX_COLORREF crFill,

const CFX_FloatRect& rcFill) {

std::unique_ptr<CPDF_PathObject> pPathObj(new CPDF_PathObject);

- CFX_PathData* pPathData = pPathObj->m_Path.GetPrivateCopy();

- pPathData->AppendRect(rcFill.left, rcFill.bottom, rcFill.right, rcFill.top);

+ pPathObj->m_Path.AppendRect(rcFill.left, rcFill.bottom, rcFill.right,

+ rcFill.top);

FX_FLOAT rgb[3];

rgb[0] = FXARGB_R(crFill) / 255.0f;