Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2305103002: Make CPDF_Path have a CFX_Path rather than inheriting (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_Path have a CFX_Path rather than inheriting Committed: https://pdfium.googlesource.com/pdfium/+/fc1d16f76f173b8437edc93dde8f9f82abb51298

Patch Set 1 #

Patch Set 2 : Move to .cpp #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -38 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_path.cpp View 1 1 chunk +73 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_path.h View 1 1 chunk +32 lines, -26 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, Lei, for review.
4 years, 3 months ago (2016-09-02 21:42:06 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2305103002/diff/20001/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp File core/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right): https://codereview.chromium.org/2305103002/diff/20001/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp#newcode1473 core/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1473: FXSYS_memcpy(Path.GetMutablePoints(), m_pPathPoints, It would be nice if CFX_PathData::m_pPoints ...
4 years, 3 months ago (2016-09-02 22:10:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305103002/40001
4 years, 3 months ago (2016-09-02 22:25:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 22:45:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/fc1d16f76f173b8437edc93dde8f9f82abb5...

Powered by Google App Engine
This is Rietveld 408576698