Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 23051003: Add support for DataTransferItemList.remove() method (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos
Visibility:
Public.

Description

Add support for DataTransferItemList.remove() method Add support for DataTransferItemList.remove() method as per the latest specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-datatransferitemlist-remove Firefox 23 and IE10 do not support DataTransferItemList yet. BUG=271424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156015

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
A LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html View 1 chunk +62 lines, -0 lines 2 comments Download
A LayoutTests/fast/events/clipboard-dataTransferItemList-remove-expected.txt View 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/dom/DataTransferItemList.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-13 12:06:49 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-13 13:19:47 UTC) #2
haraken
LGTM. Needs an approval from an API owner. https://codereview.chromium.org/23051003/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html File LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html (right): https://codereview.chromium.org/23051003/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html#newcode15 LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html:15: event.preventDefault(); ...
7 years, 4 months ago (2013-08-13 13:25:44 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-13 13:36:10 UTC) #4
do-not-use
https://codereview.chromium.org/23051003/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html File LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html (right): https://codereview.chromium.org/23051003/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html#newcode15 LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html:15: event.preventDefault(); On 2013/08/13 13:25:44, haraken wrote: > > Nit: ...
7 years, 4 months ago (2013-08-13 13:51:21 UTC) #5
haraken
On 2013/08/13 13:51:21, Christophe Dumez wrote: > https://codereview.chromium.org/23051003/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html > File LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html (right): > > https://codereview.chromium.org/23051003/diff/1/LayoutTests/fast/events/clipboard-dataTransferItemList-remove.html#newcode15 ...
7 years, 4 months ago (2013-08-13 14:05:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23051003/1
7 years, 4 months ago (2013-08-13 14:08:24 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 14:37:33 UTC) #8
Message was sent while issue was closed.
Change committed as 156015

Powered by Google App Engine
This is Rietveld 408576698