Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/tools/cert_verify_tool/cert_verify_tool_util.h

Issue 2305083002: Misc changes to cert_verify_tool for errors (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/cert_verify_tool/cert_verify_tool.cc ('k') | net/tools/cert_verify_tool/cert_verify_tool_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/cert_verify_tool/cert_verify_tool_util.h
diff --git a/net/tools/cert_verify_tool/cert_verify_tool_util.h b/net/tools/cert_verify_tool/cert_verify_tool_util.h
index fe077f65f5bb096a74b4ae4508816339ba2263c6..3ad06f80d4d2142f606d3f17a5b37981e626d5dd 100644
--- a/net/tools/cert_verify_tool/cert_verify_tool_util.h
+++ b/net/tools/cert_verify_tool/cert_verify_tool_util.h
@@ -32,8 +32,10 @@ bool ReadCertificatesFromFile(const base::FilePath& file_path,
// Parses |file_path| as a DER cert or PEM chain. If more than one cert is
// present, the first will be used as the target certificate and the rest will
-// be used as intermediates.
-void ReadChainFromFile(const base::FilePath& file_path,
+// be used as intermediates. Returns true on success. Note if the input
+// contains no certificates then the return value is true however
+// nothing is written to |target| or |intermediates.
mattm 2016/09/06 22:10:50 missing |
eroman 2016/09/06 22:32:56 Done.
+bool ReadChainFromFile(const base::FilePath& file_path,
CertInput* target,
std::vector<CertInput>* intermediates);
« no previous file with comments | « net/tools/cert_verify_tool/cert_verify_tool.cc ('k') | net/tools/cert_verify_tool/cert_verify_tool_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698