Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: net/tools/cert_verify_tool/verify_using_path_builder.cc

Issue 2305083002: Misc changes to cert_verify_tool for errors (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/cert_verify_tool/verify_using_path_builder.cc
diff --git a/net/tools/cert_verify_tool/verify_using_path_builder.cc b/net/tools/cert_verify_tool/verify_using_path_builder.cc
index 94405432760428839852dc9eeed8b15926d28b08..6df4db163599d49288587d839826665ef40de173 100644
--- a/net/tools/cert_verify_tool/verify_using_path_builder.cc
+++ b/net/tools/cert_verify_tool/verify_using_path_builder.cc
@@ -118,7 +118,7 @@ void PrintCertErrors(const net::CertErrors& errors) {
// should likely be extracted to a common location and used by unit-tests and
// other debugging needs.
for (const auto& error : errors.errors()) {
- std::cout << " " << error.type;
+ std::cout << " " << error.type << "\n";
}
}
@@ -149,7 +149,7 @@ void PrintResultPath(const net::CertPathBuilder::ResultPath* result_path,
}
// Print the errors.
- if (result_path->errors.errors().empty()) {
+ if (!result_path->errors.errors().empty()) {
eroman 2016/09/02 21:32:28 Oops! Clearly I didn't even test this when I wrot
std::cout << "Errors:\n";
PrintCertErrors(result_path->errors);
}
@@ -164,10 +164,6 @@ bool VerifyUsingPathBuilder(
const std::vector<CertInput>& root_der_certs,
const base::Time at_time,
const base::FilePath& dump_prefix_path) {
- std::cout << "NOTE: CertPathBuilder does not currently use OS trust settings "
- "(--roots must be specified).\n";
- std::cerr << "WARNING: --hostname is not yet verified with CertPathBuilder\n";
-
base::Time::Exploded exploded_time;
at_time.UTCExplode(&exploded_time);
net::der::GeneralizedTime time = ConvertExplodedTime(exploded_time);

Powered by Google App Engine
This is Rietveld 408576698